ValidateDomainAndFieldNamesAction to use domainKind generateDomainURI() when applicable#6889
Merged
ValidateDomainAndFieldNamesAction to use domainKind generateDomainURI() when applicable#6889
Conversation
…() when applicable
labkey-susanh
approved these changes
Jul 30, 2025
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We've seem some intermittent test failures on TC (StudyDatasetsTest.testDatasetRoundTripWithSpecialChars and others) since the increase of the random field name length. This is because we generate field names that are now closer to the 200 char limit but those are then used in the domain PropertyURI with a domainKind specific prefix which can fail if that string is longer than 300 chars. This PR changes the validation API to try using the DomainKind generateDomainURI() where applicable and then defaulting to a longer fake URI for other domain kinds.
Related Pull Requests
Changes